chore!: promote GkeConnectGateway to V1 #7943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bshaffer
changed the title
bshaffer
changed the title
| @@ -77,8 +79,7 @@ public function generateCredentialsTest() | |||
| $transport->addResponse($expectedResponse); | |||
| // Mock request | |||
| $name = 'name3373707'; | |||
| $request = (new GenerateCredentialsRequest()) | |||
| ->setName($name); | |||
| $request = (new GenerateCredentialsRequest())->setName($name); | |||
There was a problem hiding this comment.
I personally prefer the previous version:
$request = (new GenerateCredentialsRequest())
->setName($name);My main reason is because of the closure with "()" for the new keyboard adds a bit of noise in my head so it "feels" better having the method one line down, but it is absolutely a nit.
There was a problem hiding this comment.
I agree! Although since these files are autogenerated, we'd need to make this change in gapic-generator-php.
Hectorhammett
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING_CHANGE_REASON=major version bump
BEGIN_VERSION_OVERRIDE
GkeConnectGateway: 1.0.0
END_VERSION_OVERRIDE